Re: [PATCH v2] usb: dwc3: core: Stop processing of pending events if controller is halted

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 17, 2024 at 09:52:00PM +0530, Selvarasu Ganesan wrote:
> 
> On 9/17/2024 12:38 PM, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
> > On Tue, Sep 17, 2024 at 05:47:05AM +0000, Thinh Nguyen wrote:
> >> On Tue, Sep 17, 2024, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
> >>> On Mon, Sep 16, 2024 at 11:00:30PM +0000, Thinh Nguyen wrote:
> >>>> On Tue, Sep 17, 2024, Selvarasu Ganesan wrote:
> >>>>> This commit addresses an issue where events were being processed when
> >>>>> the controller was in a halted state. To fix this issue by stop
> >>>>> processing the events as the event count was considered stale or
> >>>>> invalid when the controller was halted.
> >>>>>
> >>>>> Fixes: fc8bb91bc83e ("usb: dwc3: implement runtime PM")
> >>>>> Cc: stable <stable@xxxxxxxxxx>
> >>>> Checkpatch doesn't like that format. Fix the Cc stable tag to below:
> >>>>
> >>>> Cc: stable@xxxxxxxxxx
> >>> What?  Why?  That should be fine, exactly what is the warning that this
> >>> gives?  That should be fine, as it's what my scripts put into patches
> >>> that I create :)
> >>>
> >> This is what checkpatch complains:
> >>
> >> WARNING:BAD_STABLE_ADDRESS_STYLE: Invalid email format for stable: 'stable <stable@xxxxxxxxxx>', prefer 'stable@xxxxxxxxxx'
> >> #23:
> >> Cc: stable <stable@xxxxxxxxxx>
> >>
> >> total: 0 errors, 1 warnings, 0 checks, 72 lines checked
> > Ugh, that's wrong, whatever you want to do here is fine.
> >
> > Someone should send a patch for checkpatch...
> >
> > thanks,
> >
> > greg k-h
> 
> Hi Greg,
> 
> However I already posted new version with address a typo mistake as 
> well. Kindly review the same.
> 
> https://lore.kernel.org/lkml/20240916231813.206-1-selvarasu.g@xxxxxxxxxxx/

It's the middle of the merge window, I'll look at it after -rc1 is out,
thanks.

greg k-h




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux