Hi, Thank you for the review. Michał Pecio <michal.pecio@xxxxxxxxx> 於 2024年9月11日 週三 下午3:38寫道: > > Hi, > > I have some Etron controller (forgot which one) but I'm not using it > because it crashes ("dies") all the time under my workloads. > > I suppose I could try your patches if I find a moment for it. > > I'm aware of one more bug which affects my Etron: if an error occurs > on an isochronous TD, two events are generated: first the error, then > "success", even if the error is on the final TRB (the common case). > Then the "success" causes "TRB DMA not part of current TD" warning. > I suspect that all Etron chips are the same. This should be easily > reproducible by unpligging an audio/video device while streaming. Hmm, I don't encounter this problem. > > Considering how utterly broken this hardware is, I think it could be > more efficient to have a single "Etron host" quirk. These bugs are > so stupid that it seems unlikely that any of Etron quirks would ever > be reused on other hardware. Of course it should still use "general" > quirks when applicable, such as "broken streams", which it does IIRC. > Ok, I will use one quirk XHCI_ETRON_HOST for these workarounds in the next patch revision. > Regards, > Michal Thanks, Kuangyi Chiang