Hello Oliver, Thank you for the feedback. >> To address the above issues without reimplementing more of CDC NCM, >> rely on and check for a specific fixed format of incoming URBs >> expected from an iOS device: >> >> * 12-byte NTH16 >> * 96-byte NDP16, allowing up to 22 DPEs (up to 21 datagrams + trailer) > > I am afraid this is an approach we must not take. We cannot rely on > a specific device's behavior in a class driver. > > This is a NACK. The `ipheth` driver, that the patch is for, is designed specifically for interacting with iPhones. iPhones' "NCM" implementation for regular tethering (sharing mobile/cellular internet with an attached Linux system) is _not_ compliant with the CDC NCM spec: * Does not have the required CDC NCM descriptors * TX (computer->phone) is not NCM-encapsulated at all Thus the `ipheth` driver does not aim to be a CDC NCM-compliant implementation and, in fact, can't be one because of the points above. For a complete spec-compliant CDC NCM implementation, there is already the `cdc_ncm` driver. This driver is used for reverse tethering (sharing computer's internet connection with an attached phone) on iPhones. This patch does not in any way change `cdc_ncm`. With all of the above, does your NACK still stand? Thanks!
