On Thu, Sep 05, 2024, Mathias Nyman wrote:
> From: Niklas Neronin <niklas.neronin@xxxxxxxxxxxxxxx>
>
> The removed debug messages trigger each time an isoc frame is handled.
> In case of an error, a dedicated debug message exists.
>
> For example, a 60fps USB camera will trigger the debug message every 0.6s.
>
> Signed-off-by: Niklas Neronin <niklas.neronin@xxxxxxxxxxxxxxx>
> Signed-off-by: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>
> ---
> drivers/usb/host/xhci-ring.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
> index 4ea2c3e072a9..e1c9838084bf 100644
> --- a/drivers/usb/host/xhci-ring.c
> +++ b/drivers/usb/host/xhci-ring.c
> @@ -3941,10 +3941,6 @@ static int xhci_get_isoc_frame_id(struct xhci_hcd *xhci,
> start_frame_id = (start_frame_id >> 3) & 0x7ff;
> end_frame_id = (end_frame_id >> 3) & 0x7ff;
>
> - xhci_dbg(xhci, "%s: index %d, reg 0x%x start_frame_id 0x%x, end_frame_id 0x%x, start_frame 0x%x\n",
> - __func__, index, readl(&xhci->run_regs->microframe_index),
> - start_frame_id, end_frame_id, start_frame);
> -
> if (start_frame_id < end_frame_id) {
> if (start_frame > end_frame_id ||
> start_frame < start_frame_id)
> --
> 2.25.1
>
Please capture this info in the tracepoint instead. Otherwise we have no
idea if the isoc is scheduled as SIA or CFI. If it's CFI, I want to know
the start frame value. Currently, I don't think you're decoding this in
the TRB tracepoints.
BR,
Thinh
