Hello.
Felipe Balbi wrote:
Why always "ick"?! Do you think OMAPs are the only boards using MUSB
out there?
err, I'm afraid you have to read more about clock framework. The clock
name should not matter when you issue clk_get().
It depends on the matching type determined from a clkdev matching
table -- see dm644x_clks[] in arch/mach-davinci/dm644x.c as an example:
'struct davinci_clk' incorporates 'struct clk_lookup', and where its 1st
member is initialized, the matching is done by device, where its second
member is initialized, the matching is done by clock name -- see
clk_find() in arch/arm/common/clkdev.c for the logic.
diff --git a/arch/arm/mach-davinci/dm644x.c
b/arch/arm/mach-davinci/dm644x.c
index 2cd0081..a0ad7b6 100644
--- a/arch/arm/mach-davinci/dm644x.c
+++ b/arch/arm/mach-davinci/dm644x.c
@@ -306,7 +306,7 @@ struct davinci_clk dm644x_clks[] = {
CLK("davinci_mmc.0", NULL, &mmcsd_clk),
CLK(NULL, "spi", &spi_clk),
CLK(NULL, "gpio", &gpio_clk),
- CLK(NULL, "usb", &usb_clk),
+ CLK("musb_hdrc", "usb", &usb_clk),
CLK(NULL, "vlynq", &vlynq_clk),
CLK(NULL, "aemif", &aemif_clk),
CLK(NULL, "pwm0", &pwm0_clk),
there you are...
Gotcha. This will match in clk_find() by both device and clock name,
so clk_get() will fail with your patch.
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
