On 9/4/24 6:01 PM, Vrastil, Michal wrote:
> This reverts commit ec6ce7075ef879b91a8710829016005dc8170f17.
>
> Fix install of WinUSB dsriver using OS descriptors.
Installation. And driver. :-)
> Without the fix the drivers is not installed correctly
> and the property 'DeviceInterfaceGUID' is missing on host side.
>
> The original change was based on assumption that the interface number
> is in the high byte of wValue but it is in the low byte, instead.
> Unfortunately, the fix is based on MS documentation which is also wrong.
>
> The actual USB request for OS descriptors (using USB analyzer) looks
> like:
>
> Offset 0 1 2 3 4 5 6 7
> 0x000 C1 A1 02 00 05 00 0A 00
>
> C1: bmRequestType (device to host, vendor, interface)
> A1: nas magic number
> 0002: wValue (2: nas interface)
> 0005: wIndex (5: get extended property i.e. nas interface GUID)
> 008E: wLength (142)
>
> The fix was tested on Windows 10 and Windows 11.
>
> Fixes: ec6ce70 ("usb: gadget: composite: fix OS descriptors w_value logic")
12 hex digits should be specified here...
> Signed-off-by: Michal Vrastil <michal.vrastil@xxxxxxxxxxxxx>
[...]
MBR, Sergey
