On Mon, Sep 02, 2024 at 08:30:19PM +0800, Zhang Zekun wrote: > devm_clk_get() and clk_prepare_enable() can be replaced by helper > function devm_clk_get_enabled(). Let's use devm_clk_get_enabled() to > simplify code and avoid calling clk_disable_unprepare(). > > Signed-off-by: Zhang Zekun <zhangzekun11@xxxxxxxxxx> Also, have you tested that this actually works? using devm can have tricky sync issues when shutting down so I'm going to start requiring that any conversions like this be proven to work properly on real hardware. thanks, greg k-h