Hi, I'm getting rid of only struct ucsi_connector_status, but my plan is to remove all command specific data structures that don't align naturally unless there are strong objections against it. Ideally we could use bitfields - that way using those structures would not be a problem - but I guess we still can't. So UCSI_FIELD() is a hack, and may be replaced in the end, but it works. I need to check if we can use bitmaps instead, but I did not get that far yet. The last patch is probable the one that you are really interested in. Let me know what you think. thanks, Heikki Krogerus (3): usb: typec: ucsi: Helper for Get Connector Status command usb: typec: ucsi: Remove struct ucsi_connector_status usb: typec: ucsi: Helpers for new GET_CONNECTOR_STATUS fields drivers/usb/typec/ucsi/psy.c | 28 +++---- drivers/usb/typec/ucsi/trace.h | 22 ++--- drivers/usb/typec/ucsi/ucsi.c | 110 ++++++++++++------------- drivers/usb/typec/ucsi/ucsi.h | 128 +++++++++++++++++++++++------ drivers/usb/typec/ucsi/ucsi_acpi.c | 7 +- 5 files changed, 179 insertions(+), 116 deletions(-) -- 2.45.2
