Hi Mario, On Tue, Aug 20, 2024 at 10:06 AM Mario Limonciello <superm1@xxxxxxxxxx> wrote: > > On 7/12/24 13:54, superm1@xxxxxxxxxx wrote: > > From: Mario Limonciello <mario.limonciello@xxxxxxx> > > > > When the system is put into S4 or S5 XHCI controllers remain in D0. This > > causes higher power consumption and may compromise energy certifications. > > Consequently some systems consume more power in S5 than s0i3. > > > > This affects all PCIe devices, but looking at breakdowns XHCI is the > > biggest offender for power consumption. > > > > This series checks if any wakeups are needed and puts controllers into D3 > > if no wakeup necessary. > > > > This series is a spiritual successor to [1] which aimed to do this more > > generally in PCI. It also accomplishes similar goals as [2], but aims for > > both S4 and S5. > > > > [1] https://lore.kernel.org/linux-pci/20231213182656.6165-1-mario.limonciello@xxxxxxx/#t > > [2] https://lore.kernel.org/linux-pci/9d2f1619-1c61-4e8c-b28d-d4eddefa45c3@xxxxxxx/T/ > > > > Mario Limonciello (2): > > xhci: pci: If no ports have wakeup enabled then disable PCI device at > > S4 > > xhci: pci: Put XHCI controllers into D3hot at shutdown > > > > drivers/usb/host/xhci-pci.c | 17 +++++++++++------ > > 1 file changed, 11 insertions(+), 6 deletions(-) > > > > Hello, > > Any feedback for this series? Does commit 0fab972eef49 ("drivers: core: Detach device from power domain on shutdown") work for your case? The commit was reverted because it regressed some DT based devices, but probably still worth doing for ACPI based systems. Kai-Heng > > Thanks,
