On Tue, Aug 20, 2024 at 10:12:55AM -0700, Stephen Boyd wrote: > Quoting Andy Shevchenko (2024-08-20 03:09:29) > > On Mon, Aug 19, 2024 at 03:38:16PM -0700, Stephen Boyd wrote: ... > > Yeah, I really think that the appearance of this thousandth time in the Git > > history has almost no value and just pollutes the commit message makes it not > > very well readable. The only outcome is exercising the compression algo used > > by Git. > > I'll leave the decision up to the maintainers. Sure! ... > > > + /* > > > + * Ensure this bridge is aware that the next bridge wants to > > > + * reassign lanes. > > > + */ > > > + for (i = 0; i < num_input_lanes; i++) > > > + if (i != input_lanes[i].logical && !num_output_lanes) > > > + return -ENOTSUPP; > > > > Besides missing {} this code is internal to the Linux kernel. Is it okay? > > ENOTSUPP is used by select_bus_fmt_recursive() so I simply followed that > style. Okay, just be aware of that side effect of that code, also checkpatch may complain (however it might be false positive). -- With Best Regards, Andy Shevchenko