On Sun, Aug 18, 2024 at 04:17:38PM -0700, Bjorn Andersson wrote: > @@ -68,6 +68,9 @@ struct pmic_glink_ucsi { > > struct work_struct notify_work; > struct work_struct register_work; > + spinlock_t state_lock; You also never initialise this lock... Lockdep would have let you know with a big splat. Johan