Hi, The two first patches prevent potential issues. The rest are just cleanups - removing duplicated or otherwise useless code. James, can you test these? I'm changing the handling of the identity discovery in patch 3/5. It would be great if you (or somebody else) could confirm that it continues to work as expected. thanks, Heikki Krogerus (5): usb: typec: ucsi: Don't truncate the reads usb: typec: ucsi: Only assign the identity structure if the PPM supports it usb: typec: ucsi: Common function for the GET_PD_MESSAGE command usb: typec: ucsi: Call CANCEL from single location usb: typec: ucsi: Remove useless error check from ucsi_read_error() drivers/usb/typec/ucsi/ucsi.c | 126 ++++++++++------------------------ drivers/usb/typec/ucsi/ucsi.h | 14 +--- 2 files changed, 39 insertions(+), 101 deletions(-) -- 2.43.0