Re: [PATCH]usblp:Remove checks no longer needed with the new runtime PM system

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 28 Dec 2009 00:52:17 +0100
Oliver Neukum <oliver@xxxxxxxxxx> wrote:

> Under the new system a device cannot be suspended against
> the driver's wish. Therefore this condition no longer needs
> to be checked for.

> -static int usblp_suspend (struct usb_interface *intf, pm_message_t message)
> +static int usblp_suspend(struct usb_interface *intf, pm_message_t message)
>  {
>  	struct usblp *usblp = usb_get_intfdata (intf);
>  
> -	/* we take no more IO */
> -	usblp->sleeping = 1;
>  	usblp_unlink_urbs(usblp);
>  #if 0 /* XXX Do we want this? What if someone is reading, should we fail? */
>  	/* not strictly necessary, but just in case */
> @@ -1393,12 +1380,11 @@ static int usblp_suspend (struct usb_interface *intf, pm_message_t message)

> -static int usblp_resume (struct usb_interface *intf)
> +static int usblp_resume(struct usb_interface *intf)
>  {
>  	struct usblp *usblp = usb_get_intfdata (intf);
>  	int r;
>  
> -	usblp->sleeping = 0;
>  	r = handle_bidir (usblp);

If you say so, I don't object. But honestly, I don't understand well how
the PM subsystem works. I don't know if I can ack this. At any rate
let's apply and see what happens.

-- Pete
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux