On Wed, Jul 31, 2024 at 09:12:27PM +0530, Radhey Shyam Pandey wrote: > Introduce dedicated field 'power_on_delay_us' in onboard platform data > and update its delay for USB5744 configuration. Hub itself requires some > delay after reset to get to state where configuration data is going to > be accepted. Without delay upcoming support for configuration via SMBUS > is reporting a failure on the first SMBus write. > > i2c 2-002d: error -ENXIO: BYPASS_UDC_SUSPEND bit configuration failed > > Similar delay is likely also required for default configuration but > because there is enough time (code execution) between reset and usage > of the hub any issue is not visible but it doesn't mean delay shouldn't > be reflected. > > Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xxxxxxx> > Suggested-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx> This constant addition of "platform data" seems to be duplicating what we did before with device tree, right? Why can't this information be there instead? thanks, greg k-h
