On Sun, Aug 4, 2024 at 11:39 PM Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote: > > On Sun, Aug 04, 2024 at 08:06:40PM -0400, crwulff@xxxxxxxxx wrote: > > diff --git a/include/uapi/linux/usb/ch9.h b/include/uapi/linux/usb/ch9.h > > index 44d73ba8788d..91f0f7e214a5 100644 > > --- a/include/uapi/linux/usb/ch9.h > > +++ b/include/uapi/linux/usb/ch9.h > > @@ -254,6 +254,9 @@ struct usb_ctrlrequest { > > #define USB_DT_DEVICE_CAPABILITY 0x10 > > #define USB_DT_WIRELESS_ENDPOINT_COMP 0x11 > > #define USB_DT_WIRE_ADAPTER 0x21 > > +/* From USB Device Firmware Upgrade Specification, Revision 1.1 */ > > +#define USB_DT_DFU_FUNCTIONAL 0x21 > > This is the only place in the entire patch where you explain what "DFU" > means. Is this really such a well-known acronym that it doesn't need to > be in the documentation or the commit message? Yeah, it would probably be good to add that to the documentation. I'll add that info. (It stands for "Device Firmware Upgrade") -- Chris Wulff