Hello linux community expert: Q: There is no fixes tag here :( A: Is it necessary to add this fixes tag? I currently don’t know how to add this tag. Q: Also you have a lot of trailing whitespace on the commit changelog, is that intentional? A: There was something wrong with the text editor I was using. Note: This is my first time submitting a patch to the Linux community. I am still familiar with the detailed rules and feel very nervous. Thanks -----邮件原件----- 发件人: gregkh@xxxxxxxxxxxxxxxxxxx <gregkh@xxxxxxxxxxxxxxxxxxx> 发送时间: 2024年7月31日 19:54 收件人: 胡连勤 <hulianqin@xxxxxxxx> 抄送: laurent.pinchart@xxxxxxxxxxxxxxxx; dan.scally@xxxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; akpm@xxxxxxxxxxxxxxxxxxxx; opensource.kernel <opensource.kernel@xxxxxxxx> 主题: Re: 答复: [PATCH v2] usb: gadget: uvc: Fixes the abnormal enumeration problem of mobile phone as UVC camera. On Wed, Jul 31, 2024 at 11:49:11AM +0000, 胡连勤 wrote: > When the phone is connected to the computer to use the webcam > function, the phone needs to be enumerated as a uvc camera function. > > Because uvc->func.bind_deactivated is configured as true in the f_uvc > driver uvc_alloc function, the usb_gadget_deactivate function is > called during the execution of the configfs_composite_bind function to > set gadget->deactivated to true, which in turn causes the > usb_gadget_connect_locked function to fail to call the corresponding > controller pullup operation (such as: dwc3_gadget_pullup, > mtu3_gadget_pullup), and the USB cannot be enumerated normally under > the uvc function combination. > > After applying this patch, we measured that under the uvc function, > the dwc3 controller and the mtu3 controller can be enumerated > normally, and the webcam function is normal. > > Fixes this by removing the setting of uvc->func.bind_deactivated to true. > > Signed-off-by: Lianqin Hu <hulianqin@xxxxxxxx> > --- > v2: > - Add "Fixes:" tag on the commit There is no fixes tag here :( Also you have a lot of trailing whitespace on the commit changelog, is that intentional? thanks, greg k-h
