On Wed, Jul 24, 2024 at 09:15:54AM +0800, Ma Ke wrote: > It could lead to error happen because the variable res is not updated if > the call to sr_share_read_word returns an error. In this particular case > error code was returned and res stayed uninitialized. > > This can be avoided by checking the return value of sr_share_read_word > and propagating the error if the read operation failed. > > Found by code review. For V1, you were given the comment that there are other functions which also suffer from this problem. You don't appear to of addressed them in this patch, nor replied saying you won't because.... Please don't ignore reviewers. Andrew
