On Mon, Jul 08, 2024 at 03:25:53PM +0100, John Keeping wrote: > Most writes to configfs handle an optional newline, but do not require > it. By using the number of bytes written as the limit for scnprintf() > it is guaranteed that the final character in the buffer will be > overwritten. > > This is expected if it is a newline but is undesirable when a string is > written "as-is" (as libusbgx does, for example). So we are changing kernel functionality because a userspace program does not work? Why not fix the userspace program? > Update the store function to strip an optional newline, matching the > behaviour of usb_string_copy(). This changes the behaviour of a lot of configfs files right? What will break if this happens? thanks, greg k-h