Hi Jakub, Thanks for this review's comments. + Allen Pais On Wed, 3 Jul 2024 at 07:12, Jakub Kicinski <kuba@xxxxxxxxxx> wrote: > > On Mon, 1 Jul 2024 15:33:27 +0530 Anand Moon wrote: > > Migrate tasklet APIs to the new bottom half workqueue mechanism. It > > replaces all occurrences of tasklet usage with the appropriate workqueue > > APIs throughout the alteon driver. This transition ensures compatibility > > with the latest design and enhances performance > > alteon ? Ok copy past the committee message, I will fix this in the next patch. This patch is just follow-up on work done by Allen Pais [1] https://lore.kernel.org/all/20240621183947.4105278-14-allen.lkml@xxxxxxxxx/ > > > - tasklet_enable(&tp->tx_tl); > > + enable_and_queue_work(system_bh_wq, &tp->tx_work); > > This is not obviously correct. Please explain why in the commit message > if you're sure this is right. Ok, I will gather all the feedback and work on these changes. And update this patch. > -- > pw-bot: cr Thanks -Anand
