On Thu, Jun 27, 2024 at 9:14 AM Johan Hovold <johan@xxxxxxxxxx> wrote: > > On Sat, Jun 22, 2024 at 09:00:17PM +0200, Martin Blumenstingl wrote: > > On Wed, Jun 19, 2024 at 3:35 PM Paul Spooren <mail@xxxxxxxxxxx> wrote: > > > > On 7. May 2024, at 15:15, Corentin Labbe <clabbe@xxxxxxxxxxxx> wrote: > > > > > > > > The CH348 is an USB octo port serial adapter. > > > > The device multiplexes all 8 ports in the same pair of Bulk endpoints. > > > > Since there is no public datasheet, unfortunately it remains some magic values > > > > > > > > Signed-off-by: Corentin Labbe <clabbe@xxxxxxxxxxxx> > > > Tested-by: Paul Spooren <mail@xxxxxxxxxxx <mailto:mail@xxxxxxxxxxx>> > > > Thanks Paul! > > Johan, is the Tested-by something that you can fix up while applying? > > Sure. Great, thank you! > > Speaking of applying this patch, it would be great to have it queued > > for Linux 6.11. > > If you have any questions or review comments then please let Corentin > > and me know. > > If you think the outstanding issues have been addressed now then I'll > find some time to review it again. The issue reported originally by Nicolas and then confirmed by Corentin in [0] is indeed fixed with this v7. I am not aware of any other functional issues. There's additional features that the hardware supports which the driver doesn't yet - for example modem control. Those features can be implemented later - as necessary. Best regards, Martin [0] https://lore.kernel.org/lkml/ZVtRNZmCMImCT9sN@Red/
