On Fri, Jun 14, 2024 at 03:37:53PM +0300, Mika Westerberg wrote: > On Fri, Jun 14, 2024 at 02:19:58PM +0200, Greg KH wrote: > > On Fri, Jun 14, 2024 at 03:15:06PM +0300, Mika Westerberg wrote: > > > Hi all, > > > > > > This series adds USB4 link sideband access through debugfs. This can be > > > used to run port operations etc. from userspace usable for example in > > > manufacturing. The other feature is receiver lane margining support for > > > retimers with similar use case. > > > > > > Mika Westerberg (6): > > > thunderbolt: Move usb4_port_margining_caps() declaration into correct place > > > thunderbolt: Make usb4_port_sb_read/write() available outside of usb4.c > > > thunderbolt: Add sideband register access to debugfs > > > thunderbolt: Split out margining from USB4 port > > > thunderbolt: Make margining functions accept target and retimer index > > > thunderbolt: Add receiver lane margining support for retimers > > > > > > drivers/thunderbolt/Kconfig | 11 +- > > > drivers/thunderbolt/debugfs.c | 623 ++++++++++++++++++++++++++-------- > > > drivers/thunderbolt/retimer.c | 53 +-- > > > drivers/thunderbolt/sb_regs.h | 9 + > > > drivers/thunderbolt/tb.h | 45 ++- > > > drivers/thunderbolt/usb4.c | 183 +++++----- > > > 6 files changed, 655 insertions(+), 269 deletions(-) > > > > No hint as to what changed from v1? > > Oh, crap. I added it but added for the v1 cover letter by accident :( > Sorry about that. The changelog is below: > > Previous version can be found: > > https://lore.kernel.org/linux-usb/20240610100627.3521887-1-mika.westerberg@xxxxxxxxxxxxxxx/ > > Changes from previous version: > > - Do not store debugfs dentry pointer, instead look it up when needed. Great, thanks for the change, looks good! greg k-h