Re: [PATCH 3/6] thunderbolt: Add sideband register access to debugfs

[Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>]

On Mon, Jun 10, 2024 at 12:32:46PM +0200, Greg KH wrote:
> On Mon, Jun 10, 2024 at 01:06:24PM +0300, Mika Westerberg wrote:
> > +void tb_retimer_debugfs_init(struct tb_retimer *rt)
> > +{
> > +	rt->debugfs_dir = debugfs_create_dir(dev_name(&rt->dev),
> > +					     tb_debugfs_root);
> 
> Why save this in a local variable?  Why not just look it up when you
> want to remove it?

I think the only reason is that we add margining_retimer_init() in the
subsequent patch that then uses rt->debugfs_dir to add the margining
directory.

I will change this to use local variable and look it up in v2.

Thanks!