Hi Oliver, On 27/05/24 1:58 pm, Oliver Neukum wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know > the content is safe > > On 22.05.24 16:08, Parthiban Veerasooran wrote: > > Hi, > > however you solve this, the descriptors are stored in wire order. > >> + if (dev->udev->descriptor.idVendor == 0x184F && >> + dev->udev->descriptor.idProduct == 0x0051) >> + write_buf |= LED_GPIO_CFG_LED_SEL; > > This needs to be > > if (dev->udev->descriptor.idVendor == cpu_to_le16(0x184F) && > dev->udev->descriptor.idProduct == cpu_to_le16(0x0051)) > > HTH > Oliver Thanks for reviewing the patch. This one was already pointed out by Simon Horman and kernel test robot. I agreed that but unfortunately there was an another proposal by Woojung with EEPROM. So I asked to discard this patch proceeding further and sent out another fix patch for supporting with Woojung's EEPROM proposal. My request to discard this patch: --------------------------------- https://lore.kernel.org/netdev/3e2b2b18-4dd9-4b22-9690-01e1bdd44828@xxxxxxxxxxxxx/ My request to review the other/new patch: ----------------------------------------- https://lore.kernel.org/netdev/20240523085314.167650-1-Parthiban.Veerasooran@xxxxxxxxxxxxx/ The above patch has been already reviewed by both Woojung and Simon: -------------------------------------------------------------------- https://lore.kernel.org/netdev/20240523144056.GO883722@xxxxxxxxxx/ https://lore.kernel.org/netdev/BL0PR11MB2913CE81AFC08F2D619C3B6CE7F42@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ Hope this clarifies. Best regards, Parthiban V
