Re: [RFC PATCH] USB: usb-storage: add priority boost to workaround Intel Value SSD hang

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Matt, ...

On Thu, Dec 17, 2009 at 04:07:55PM -0800, Matthew Dharm wrote:
> On Thu, Dec 17, 2009 at 03:13:22PM -0800, Arthur Jones wrote:
> > The Intel Value SSD has a bug where it will lock
> > solid if it encounters a delay between the command
> > and data phases of the usb bulk storage transactions.
> > This bug is easily reproduced by adding a 2.5sec
> > delay just before the comment labelled DATA STAGE
> > in drivers/usb/storage/transport.c in
> > usb_stor_Bulk_transport().
> > 
> > We can't really guarantee to not hit this bug, but
> > if we decrease our nice level, we may be somewhat
> > less likely to see this already rare issue surface.
> 
> I have two issues with this:
> 
> 1) I'm not clear on the side effects of changing our priority.  We've had
> issues in the past because block-storage devices are tied closely into the
> memory management system, and I'd hate to see another issue like those crop
> up because we're wagging our priority around.  That said, I have no direct
> knowledge of anything that would cause an issue...
> 
> 2) All this patch does is cover up a pretty serious bug, without completely
> covering it up.  The end-user still winds up with an unreliable storage
> device.  With your patch, it may simply be a little less unreliable.

Yeah, it sounds like you don't think that
adding this code is worth a minor bump in
reliability -- I can't really argue w/ that...

> I think I would rather let people know that their device is unreliable, and
> encourage them to get a firmware update from Intel.  Actually, didn't Intel
> just release a firmware update for these a few days ago?

Thanks for having a look...  I don't know
anything about a f/w update, Intel has since
sold off this business and AFAIK, no longer
supports this device.  If you have any links
I would love to follow up on them.  The model
number on the device is Intel Z-U130.  I would
be very happy if this could be fixed in f/w.

Arthur

> 
> Matt
> 
> -- 
> Matthew Dharm                              Home: mdharm-usb@xxxxxxxxxxxxxxxxxx 
> Maintainer, Linux USB Mass Storage Driver
> 
> M:  No, Windows doesn't have any nag screens.
> C:  Then what are those blue and white screens I get every day?
> 					-- Mike and Cobb
> User Friendly, 1/4/1999


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux