Hi Andrew, On 22/05/24 10:14 pm, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Wed, May 22, 2024 at 07:38:17PM +0530, Parthiban Veerasooran wrote: >> By default, LAN9500A configures the external LEDs to the below function. >> nSPD_LED -> Speed Indicator >> nLNKA_LED -> Link and Activity Indicator >> nFDX_LED -> Full Duplex Link Indicator >> >> But, EVB-LAN8670-USB uses the below external LEDs function which can be >> enabled by writing 1 to the LED Select (LED_SEL) bit in the LAN9500A. >> nSPD_LED -> Speed Indicator >> nLNKA_LED -> Link Indicator >> nFDX_LED -> Activity Indicator > > What else can the LEDs indicate? There is no other indications. > >> + /* Set LED Select (LED_SEL) bit for the external LED pins functionality >> + * in the Microchip's EVB-LAN8670-USB 10BASE-T1S Ethernet device which > > Is this a function of the USB dongle? Or a function of the PHY? It is the function of USB dongle. Sorry Andrew, I am not going to proceed further with this patch as Woojung pointed out EEPROM approach can be used instead of updating the driver. I tried that as well. So please discard this patch. But the EEPROM approach mentioned by Woojung is needed a fix in the driver to work properly. I will send out that fix patch separately. Please review it. Thanks for your understanding. Best regards, Parthiban V > > Andrew
