On Mon, May 06, 2024 at 01:03:12PM +0300, Heikki Krogerus wrote: > On Fri, May 03, 2024 at 12:39:17AM +0000, Jameson Thies wrote: > > From: Abhishek Pandit-Subedi <abhishekpandit@xxxxxxxxxxxx> > > > > ucsi_register_altmode checks IS_ERR on returned pointer and treats > > NULL as valid. When CONFIG_TYPEC_DP_ALTMODE is not enabled > > ucsi_register_displayport returns NULL which causese a NULL pointer > > dereference in trace. Rather than return NULL, call > > typec_port_register_altmode to register DisplayPort alternate mode > > as a non-controllable mode when CONFIG_TYPEC_DP_ALTMODE is not enabled. > > > > Reviewed-by: Jameson Thies <jthies@xxxxxxxxxx> > > Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@xxxxxxxxxxxx> > > You delivered the patch, so you should have used SoB instead of > Reviewed-by tag: > https://docs.kernel.org/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by Not "should", that would be "must". I can't take it like this, sorry. greg k-h
