Hello Diogo Ivo,
Commit 27ffe4ff0b33 ("usb: typec: ucsi: Only enable supported
notifications") from Mar 27, 2024 (linux-next), leads to the
following Smatch static checker warning:
drivers/usb/typec/ucsi/ucsi.c:1671 ucsi_get_supported_notifications()
warn: was expecting a 64 bit value instead of '((((1))) << (24))'
drivers/usb/typec/ucsi/ucsi.c
1665 static u64 ucsi_get_supported_notifications(struct ucsi *ucsi)
1666 {
1667 u8 features = ucsi->cap.features;
1668 u64 ntfy = UCSI_ENABLE_NTFY_ALL;
1669
1670 if (!(features & UCSI_CAP_ALT_MODE_DETAILS))
--> 1671 ntfy &= ~UCSI_ENABLE_NTFY_CAM_CHANGE;
ntfy is a u64 but UCSI_ENABLE_NTFY_CAM_CHANGE is unsigned long. So on
a 32 bit system this will clear the high 32 bits. So far as I can see
ntfy should just be a u32. Either way, the types should match.
BIT_ULL() is the way to do that if it really needs to be a u64.
1672
1673 if (!(features & UCSI_CAP_PDO_DETAILS))
1674 ntfy &= ~(UCSI_ENABLE_NTFY_PWR_LEVEL_CHANGE |
1675 UCSI_ENABLE_NTFY_CAP_CHANGE);
1676
1677 if (!(features & UCSI_CAP_EXT_SUPPLY_NOTIFICATIONS))
1678 ntfy &= ~UCSI_ENABLE_NTFY_EXT_PWR_SRC_CHANGE;
1679
1680 if (!(features & UCSI_CAP_PD_RESET))
1681 ntfy &= ~UCSI_ENABLE_NTFY_PD_RESET_COMPLETE;
1682
1683 return ntfy;
1684 }
regards,
dan carpenter
