Re: [PATCH] docs: usb:gadget:hid: fix hid_gadget_test code in documentation of hid section

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 06, 2024 at 10:44:08AM +0800, qiurui wrote:
> Fix bzero buffer before read()

why would we want to do that?

> Signed-off-by: qiurui <qiurui@xxxxxxxxxx>
> ---
>  Documentation/usb/gadget_hid.rst | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/usb/gadget_hid.rst b/Documentation/usb/gadget_hid.rst
> index e623416de4f1..c4ee81a6b48e 100644
> --- a/Documentation/usb/gadget_hid.rst
> +++ b/Documentation/usb/gadget_hid.rst
> @@ -410,6 +410,7 @@ Sample code::
>  		}
>  
>  		if (FD_ISSET(fd, &rfds)) {
> +			bzero(buf, SIZE);
>  			cmd_len = read(fd, buf, BUF_LEN - 1);
>  			printf("recv report:");
>  			for (i = 0; i < cmd_len; i++)
> @@ -419,6 +420,7 @@ Sample code::
>  
>  		if (FD_ISSET(STDIN_FILENO, &rfds)) {
>  			memset(report, 0x0, sizeof(report));
> +			bzero(buf, SIZE);
>  			cmd_len = read(STDIN_FILENO, buf, BUF_LEN - 1);
>  
>  			if (cmd_len == 0)
> -- 
> 2.34.1
> 
> 




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux