On 22/04/2024 11:37, Mohammad Shehar Yaar Tausif wrote: > Convert USB UHCI bindings to DT schema. Please mention changes from pure conversion, so documenting aspeed compatibles and missing properties. > > Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@xxxxxxxxx> > --- ... ... > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + > +if: This should be under allOf > + properties: > + compatible: > + contains: > + const: generic-uhci > +then: > + allOf: > + - $ref: usb-hcd.yaml This is confusing. Aspeed is not different here. > + if: > + properties: > + compatible: > + contains: > + enum: > + - aspeed,ast2400-uhci > + - aspeed,ast2500-uhci > + - aspeed,ast2600-uhci > + then: > + properties: > + '#ports': > + $ref: /schemas/types.yaml#/definitions/uint32 And the #ports property looks valid for generic-ahci. Why do you think it is not valid? > + clocks: > + maxItems: 1 Define properties top-level. > + required: > + - clocks This looks required for generic-uhci as well. Why did you put it only for aspeed? Best regards, Krzysztof
