On Sun, Apr 21, 2024 at 03:41:23PM +0000, Chris Wulff wrote: > > > Any specific reason you didn't cc: the maintainer here? Or the > > developers who touched the file last? scripts/get_maintainer.pl is your > > friend :) > > Thanks for the script reference. I looked in MAINTAINERS and didn't see one for the file(s) I am patching. As luck would have it, the first person on the list is you :). I will CC the emails from the script in the future. I am struggling a bit with our Outlook 365 server as it doesn't allow SMTP mail with any kind of basic authentication so I am unable to directly use git send-email. You might want to have your email client wrap lines at a sane length as well :) > > > diff --git a/drivers/usb/gadget/function/f_uac1.c b/drivers/usb/gadget/function/f_uac1.c > > > index 7de74a3dd392..100169d6dca7 100644 > > > --- a/drivers/usb/gadget/function/f_uac1.c > > > +++ b/drivers/usb/gadget/function/f_uac1.c > > > @@ -377,24 +377,10 @@ enum { > > > STR_AS_OUT_IF_ALT1, > > > STR_AS_IN_IF_ALT0, > > > STR_AS_IN_IF_ALT1, > > > + NUM_STR_DESCRIPTORS, > > > > Does this require a change to the Documentation/ABI/ files as well? > > I will add the additional configfs strings to Documentation/ABI/testing/configfs-usb-gadget-uac1 and Documentation/usb/gadget-testing.rst > Are you aware of any other documentation that I might need to update? Those are the ones I've found so far. That's a good start and probably is all that is needed for now, thanks. greg k-h