On Mon, Apr 15, 2024 at 07:26:25AM -0700, Coia Prant wrote:
> Update the USB serial option driver to support Longsung U8300/U9300.
> Signed-off-by: Coia Prant <coiaprant@xxxxxxxxx>
> Reviewed-by: Lars Melin <larsm17@xxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> Cc: netdev@xxxxxxxxxxxxxxx
> ---
Thanks for the update. Next time, remember to include a short changelog
here when revising a patch.
> drivers/usb/serial/option.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 55a65d941ccb..27a116901459 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -412,6 +412,10 @@ static void option_instat_callback(struct urb *urb);
> */
> #define LONGCHEER_VENDOR_ID 0x1c9e
>
> +/* Longsung products */
> +#define LONGSUNG_U8300_PRODUCT_ID 0x9b05
> +#define LONGSUNG_U9300_PRODUCT_ID 0x9b3c
> +
> /* 4G Systems products */
> /* This one was sold as the VW and Skoda "Carstick LTE" */
> #define FOUR_G_SYSTEMS_PRODUCT_CARSTICK_LTE 0x7605
> @@ -2054,6 +2058,10 @@ static const struct usb_device_id option_ids[] = {
> .driver_info = RSVD(4) },
> { USB_DEVICE(LONGCHEER_VENDOR_ID, ZOOM_PRODUCT_4597) },
> { USB_DEVICE(LONGCHEER_VENDOR_ID, IBALL_3_5G_CONNECT) },
> + { USB_DEVICE(LONGCHEER_VENDOR_ID, LONGSUNG_U8300_PRODUCT_ID),
> + .driver_info = RSVD(4) | RSVD(5) },
> + { USB_DEVICE(LONGCHEER_VENDOR_ID, LONGSUNG_U9300_PRODUCT_ID),
> + .driver_info = RSVD(0) | RSVD(4) },
I dropped the product defines in favour of a comment (as they don't
really add any value and we don't have to worry about keeping the
defines sorted).
I also trimmed the commit message slightly before applying.
The end-result is here:
https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/commit/?h=usb-linus&id=cf16ffa17c398434a77b8a373e69287c95b60de2
Johan
