On Wed, Apr 17, 2024, Greg Kroah-Hartman wrote: > On Tue, Apr 16, 2024 at 11:41:36PM +0000, Thinh Nguyen wrote: > > The xhci_plat.h should not need to include the entire xhci.h header. > > This can cause redefinition in dwc3 if it selectively includes some xHCI > > definitions. This is a prerequisite change for a fix to disable suspend > > during initialization for dwc3. > > > > Cc: stable@xxxxxxxxxxxxxxx > > Signed-off-by: Thinh Nguyen <Thinh.Nguyen@xxxxxxxxxxxx> > > --- > > drivers/usb/host/xhci-plat.h | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/usb/host/xhci-plat.h b/drivers/usb/host/xhci-plat.h > > index 2d15386f2c50..6475130eac4b 100644 > > --- a/drivers/usb/host/xhci-plat.h > > +++ b/drivers/usb/host/xhci-plat.h > > @@ -8,7 +8,9 @@ > > #ifndef _XHCI_PLAT_H > > #define _XHCI_PLAT_H > > > > -#include "xhci.h" /* for hcd_to_xhci() */ > > +struct device; > > +struct platform_device; > > +struct usb_hcd; > > > > struct xhci_plat_priv { > > const char *firmware_name; > > -- > > 2.28.0 > > > > Seems to break the build :( Oops.. I missed checking for xhci-rzv2m build. Thanks, Thinh