Re: [PATCH] usb/dwc3: replace of_node_put with __free

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Andrew Ballance <andrewjballance@xxxxxxxxx>
Subject: Re: [PATCH] usb/dwc3: replace of_node_put with __free
From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 9 Apr 2024 17:19:27 +0200
Cc: linux-kernel@xxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx, Thinh.Nguyen@xxxxxxxxxxxx, linux-kernel-mentees@xxxxxxxxxxxxxxxxxxxxxxxxx, skhan@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20240406024838.537630-1-andrewjballance@gmail.com>
References: <20240406024838.537630-1-andrewjballance@gmail.com>

On Fri, Apr 05, 2024 at 09:48:38PM -0500, Andrew Ballance wrote:
> this relaces instances of of_node_put with __free(device_node)
> in drivers/usb/dwc3/core.c

Why?  You need to always describe _why_ you do something, not _what_ you
do.

thanks,

greg k-h

References:
- [PATCH] usb/dwc3: replace of_node_put with __free
  - From: Andrew Ballance

Prev by Date: [PATCH v2 3/3] usb: typec: ucsi_glink: drop special handling for CCI_BUSY
Next by Date: Re: [PATCHv3 2/2] usb: typec: anx7688: Add driver for ANX7688 USB-C HDMI bridge
Previous by thread: Re: [PATCH] usb/dwc3: replace of_node_put with __free
Next by thread: [usb:usb-linus] BUILD SUCCESS d464dac47260a33add5a206fd3289ec1216e8435
Index(es):
- Date
- Thread

[Index of Archives] [Linux Media] [Linux Input] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI] [Old Linux USB Devel Archive]

Powered by Linux