On Tue, Apr 09, 2024 at 02:27:37AM +0000, Pavan Holla wrote:
> Implementation of a UCSI transport driver for ChromeOS.
The patch generally looks good to me just a few nits.
> This driver will be loaded if the ChromeOS EC implements a PPM.
Replied in v3, the patch (and the series) don't reflect the message.
> diff --git a/drivers/usb/typec/ucsi/cros_ec_ucsi.c b/drivers/usb/typec/ucsi/cros_ec_ucsi.c
> [...]
> +static void cros_ucsi_work(struct work_struct *work)
> +{
> + struct cros_ucsi_data *udata = container_of(work, struct cros_ucsi_data, work);
> + u32 cci;
> + int ret;
> +
> + ret = cros_ucsi_read(udata->ucsi, UCSI_CCI, &cci, sizeof(cci));
> + if (ret)
> + return;
`ret` can be dropped.
> +static const struct platform_device_id cros_ucsi_id[] = {
> + { DRV_NAME, 0},
To be neat, append an extra space after `0`.
