On Thu, Apr 04, 2024 at 10:42:22AM +0530, Krishna Kurapati wrote:
> +static int dwc3_get_num_ports(struct dwc3 *dwc)
> +{
> + void __iomem *base;
> + u8 major_revision;
> + u32 offset;
> + u32 val;
> +
> + /*
> + * Remap xHCI address space to access XHCI ext cap regs since it is
> + * needed to get information on number of ports present.
> + */
> + base = ioremap(dwc->xhci_resources[0].start,
> + resource_size(&dwc->xhci_resources[0]));
> + if (!base)
> + return PTR_ERR(base);
This is obviously still broken. You need to update the return value as
well.
Fix in v20.
Johan
