Hi,
On Mon, Dec 14, 2009 at 10:22:32PM +0100, ext Rick L. Vinyard Jr. wrote:
Signed-off-by: Rick L. Vinyard, Jr <rvinyard@xxxxxxxxxxx>
there are plenty of style mistakes in this patch. the body message
description which you put below should be above the signed-off-by line,
multi-lined comments are of the form:
/*
* multi lined comment
* goes here
*/
remove the commented code like /* hid_debug = 0 */
and some others.. please run your patch through scripts/checkpatch.pl
--strict and fix the errors and warnings reported.
please take a look at Documentation/SubmittingPatches and
Documentation/CodingStyle for further reference.
When sending the patch, you could also use git send-email to avoid the
problem you had with 'mail'.
+static int __init g13_init(void)
+{
+ pr_debug("g13 HID driver loaded");
don't pr_debug() here.
+ return hid_register_driver(&g13_driver);
+}
+
+static void __exit g13_exit(void)
+{
+ pr_debug("g13 HID driver unloaded");
nor here.
+ hid_unregister_driver(&g13_driver);
+}
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
