On Tue, Mar 19, 2024 at 03:43:09PM +0800, Kyle Tso wrote:
> The attribute writing should return the number of bytes used from the
> buffer on success.
>
> Fixes: a7cff92f0635 ("usb: typec: USB Power Delivery helpers for ports and partners")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Kyle Tso <kyletso@xxxxxxxxxx>
Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> ---
> drivers/usb/typec/class.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
> index 389c7f0b8d93..9610e647a8d4 100644
> --- a/drivers/usb/typec/class.c
> +++ b/drivers/usb/typec/class.c
> @@ -1310,6 +1310,7 @@ static ssize_t select_usb_power_delivery_store(struct device *dev,
> {
> struct typec_port *port = to_typec_port(dev);
> struct usb_power_delivery *pd;
> + int ret;
>
> if (!port->ops || !port->ops->pd_set)
> return -EOPNOTSUPP;
> @@ -1318,7 +1319,11 @@ static ssize_t select_usb_power_delivery_store(struct device *dev,
> if (!pd)
> return -EINVAL;
>
> - return port->ops->pd_set(port, pd);
> + ret = port->ops->pd_set(port, pd);
> + if (ret)
> + return ret;
> +
> + return size;
> }
>
> static ssize_t select_usb_power_delivery_show(struct device *dev,
> --
> 2.44.0.291.gc1ea87d7ee-goog
--
heikki
