Great first cut, but please: - your patch was linewrapped, please fix your email client to not do that. - You did not provide a signed-off-by: line as required by the file Documentation/SubmittingPatches - You did not provide a good changelog entry in the body of the email explaining what this patch is, and what it does. - you did not cc: the HID maintainer, who is the proper person to apply this patch. Try using the script, scripts/get_maintainer.pl to figure out who to send patches to. - Can you run your patch through the scripts/checkpatch.pl script and fix the errors and warnings it reports? It would have caught many of the above mentioned things. Care to try again? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html