That link is to a question that the submitter asked, and nobody responded to it. It seems that this patch stems from an incomplete reading of the kernel documentation. Those docs say: > SPP (Standard Parallel Port) functions modify so-called SPP registers: > data, status, and control. The hardware may not actually have > registers exactly like that, but the PC does and this interface is > modelled after common PC implementations. Other low-level drivers may > be able to emulate most of the functionality. So, the PARPORT_MODE_PCSPP flag denotes the availability of the SPP port functions, not any fields in a struct. On Tue, 2024-03-12 at 08:38 +0100, Johan Hovold wrote: > On Mon, Mar 11, 2024 at 11:50:26PM -0600, Alex Henrie wrote: > > Please write a proper commit message here explaining why this patch is > needed. You can keep the link if it's relevant, but you still need to > make the patch self-contained. > > > Link: http://lists.infradead.org/pipermail/linux-parport/2024-February/001237.html > > Signed-off-by: Alex Henrie <alexhenrie24@xxxxxxxxx> > > Johan
