On 08/03/2024 09:30, Xu Yang wrote: >>> + - enum: >>> + - fsl,imx8mm-usb >>> + - fsl,imx8mn-usb >>> + - const: fsl,imx7d-usb >>> + - const: fsl,imx27-usb >>> + - items: >>> + - enum: >>> + - fsl,imx6sll-usb >>> + - fsl,imx7ulp-usb >>> + - const: fsl,imx6ul-usb >>> + - const: fsl,imx27-usb >>> + >>> + clocks: >>> + minItems: 1 >>> + maxItems: 3 >> >> >> No need to, it's already in common. Drop clocks. > > No. I cannot remove clocks property in this yaml since the usb node may use assigned-clocks > and assigned-clock-parents. Then dtschema will have warning like below patch: > https://lore.kernel.org/all/20230508071837.68552-1-krzysztof.kozlowski@xxxxxxxxxx/ This was a year ago, so please check if it is still the case. With latest dtschema. If it is still the case, then indeed keep clocks here. Best regards, Krzysztof