Re: [RFC 3/3] arm64: dts: qcom: sa8775p-ride: Enable support for firmware managed resources

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/6/2024 2:37 AM, Konrad Dybcio wrote:


On 3/5/24 19:25, Sriram Dash wrote:
On 3/5/2024 11:33 PM, Sriram Dash wrote:
On 3/5/2024 10:38 PM, Krzysztof Kozlowski wrote:
On 05/03/2024 17:57, Sriram Dash wrote:
Establish the channel and domain mapping for the power domains to connect
with firmware, enabling the firmware to handle the assigned resources.
Since these delegated resources will remain invisible to the operating
system, ensure that any references to them are removed.

Signed-off-by: Sriram Dash <quic_sriramd@xxxxxxxxxxx>
---
  arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 96 +++++++++++++++++++++++++------
  1 file changed, 77 insertions(+), 19 deletions(-)

Do not mix DTS patches with submissions to netdev or USB.

Please put it inside your internal guides, so you will not be repeating
this over and over.


Sure. Will take care. Thanks.


diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
index 26ad05b..b6c9cac 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
+++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
@@ -764,8 +764,18 @@
  };
  &usb_0 {
-    pinctrl-names = "default";
-    pinctrl-0 = <&usb0_en_state>;
+    /delete-property/ clocks;
+    /delete-property/ clock-names;
+    /delete-property/ assigned-clocks;
+    /delete-property/ assigned-clock-rates;
+    /delete-property/ required-opps;
+    /delete-property/ resets;
+    /delete-property/ interconnects;
+    /delete-property/ interconnect-names;

This is totally unacceptable.. And especially makes no sense given
ride is likely the only sa8775 board in existence..


Sure Konrad.
Will update the patches on top of the scmi based dt
for sa8775.

+
+    power-domains = <TODO>, <TODO>;

This wasn't even tested.


This is tested with the specific power domains in place
of <TODO>. SCMI interface is used for the power domains.

I'm sorry, but "break compilation successfully" is not a valid
test result..

Konrad




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux