On Tue, Mar 05, 2024 at 01:47:05PM +0530, Krishna Kurapati PSSNV wrote: > On 3/5/2024 12:39 PM, Johan Hovold wrote: > > On Tue, Mar 05, 2024 at 09:51:43AM +0530, Krishna Kurapati wrote: > > You should update the Kconfig entry for USB_DWC3_QCOM as well and drop > > the ACPI dependency. > > Missed it. Thanks for the catch. The following is the one right ? > > diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig > index 5fc27b20df63..31078f3d41b8 100644 > --- a/drivers/usb/dwc3/Kconfig > +++ b/drivers/usb/dwc3/Kconfig > @@ -131,7 +131,7 @@ config USB_DWC3_QCOM > tristate "Qualcomm Platform" > depends on ARCH_QCOM || COMPILE_TEST > depends on EXTCON || !EXTCON > - depends on (OF || ACPI) > + depends on OF Right. > > Looks good to me otherwise. > > Thanks for the review. Wanted to reply to your comments on multiport > series depending on how this patch goes in upstream. > > Can I push out v2 or wait for a couple of days (as a standard practice > before putting a new version) ? I think you can send a v2 straight away in this case. Johan
