On Fri, Feb 23, 2024 at 06:00:16PM +0800, Zijun Hu wrote: > USB driver defines macro @USB_CTRL_SET_TIMEOUT for sending control message > and @USB_CTRL_GET_TIMEOUT for receiving, but sierra_get_swoc_info() wrongly > uses @USB_CTRL_SET_TIMEOUT as argument of usb_control_msg() to receive > control message, fixed by using @USB_CTRL_GET_TIMEOUT to receive message. You do realize they are both the same value, right? Why don't we just change it to USB_CTRL_TIMEOUT so that people don't think changing this matters? thanks, greg k-h