Re: [PATCH 3/3] arm64: dts: qcom: pm6150: define USB-C related blocks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I know that some interrupts have both for PM8150B, but for PM6150 all interrupts are rising.
Please look at the downstream kernel:
https://git.codelinaro.org/clo/la/kernel/msm-4.14/-/blob/187022f2721d584ac4ec92c0ac1af77da487521d/arch/arm64/boot/dts/qcom/pm6150.dtsi#L319
https://git.codelinaro.org/clo/la/kernel/msm-4.14/-/blob/187022f2721d584ac4ec92c0ac1af77da487521d/arch/arm64/boot/dts/qcom/pm8150b.dtsi#L292

---
Best wishes
Danila

On 2/18/24 02:19, Bryan O'Donoghue wrote:
On 17/02/2024 16:32, Danila Tikhonov wrote:
Define VBUS regulator and the Type-C handling block as present on the
Quacomm PM6150 PMIC.

Signed-off-by: Danila Tikhonov <danila@xxxxxxxxxxx>

+        pm6150_typec: typec@1500 {
+            compatible = "qcom,pm6150-typec,
+                      qcom,pm8150b-typec";
+            reg = <0x1500>, <0x1700>;
+            interrupts = <0x0 0x15 0x00 IRQ_TYPE_EDGE_RISING>,
+                     <0x0 0x15 0x01 IRQ_TYPE_EDGE_RISING>,
+                     <0x0 0x15 0x02 IRQ_TYPE_EDGE_RISING>,
+                     <0x0 0x15 0x03 IRQ_TYPE_EDGE_RISING>,
+                     <0x0 0x15 0x04 IRQ_TYPE_EDGE_RISING>,
+                     <0x0 0x15 0x05 IRQ_TYPE_EDGE_RISING>,
+                     <0x0 0x15 0x06 IRQ_TYPE_EDGE_RISING>,
+                     <0x0 0x15 0x07 IRQ_TYPE_EDGE_RISING>,
+                     <0x0 0x17 0x00 IRQ_TYPE_EDGE_RISING>,
+                     <0x0 0x17 0x01 IRQ_TYPE_EDGE_RISING>,
+                     <0x0 0x17 0x02 IRQ_TYPE_EDGE_RISING>,
+                     <0x0 0x17 0x03 IRQ_TYPE_EDGE_RISING>,
+                     <0x0 0x17 0x04 IRQ_TYPE_EDGE_RISING>,
+                     <0x0 0x17 0x05 IRQ_TYPE_EDGE_RISING>,
+                     <0x0 0x17 0x06 IRQ_TYPE_EDGE_RISING>,
+                     <0x0 0x17 0x07 IRQ_TYPE_EDGE_RISING>;
+            interrupt-names = "or-rid-detect-change",
+                      "vpd-detect",
+                      "cc-state-change",
+                      "vconn-oc",
+                      "vbus-change",
+                      "attach-detach",
+                      "legacy-cable-detect",
+                      "try-snk-src-detect",
+                      "sig-tx",
+                      "sig-rx",
+                      "msg-tx",
+                      "msg-rx",
+                      "msg-tx-failed",
+                      "msg-tx-discarded",
+                      "msg-rx-discarded",
+                      "fr-swap";
+            status = "disabled";
+        };

Should all of these be rising ? Looks incorrect to me.

Please review: arch/arm64/boot/dts/qcom/pm8150b.dtsi

pm8150b_typec: typec@1500 {
        compatible = "qcom,pm8150b-typec";
        status = "disabled";
        reg = <0x1500>,
              <0x1700>;

    interrupts = <0x2 0x15 0x00 IRQ_TYPE_EDGE_RISING>,
             <0x2 0x15 0x01 IRQ_TYPE_EDGE_BOTH>,
             <0x2 0x15 0x02 IRQ_TYPE_EDGE_RISING>,
             <0x2 0x15 0x03 IRQ_TYPE_EDGE_BOTH>,
             <0x2 0x15 0x04 IRQ_TYPE_EDGE_RISING>,
             <0x2 0x15 0x05 IRQ_TYPE_EDGE_RISING>,
             <0x2 0x15 0x06 IRQ_TYPE_EDGE_BOTH>,
             <0x2 0x15 0x07 IRQ_TYPE_EDGE_RISING>,
             <0x2 0x17 0x00 IRQ_TYPE_EDGE_RISING>,
             <0x2 0x17 0x01 IRQ_TYPE_EDGE_RISING>,
             <0x2 0x17 0x02 IRQ_TYPE_EDGE_RISING>,
             <0x2 0x17 0x03 IRQ_TYPE_EDGE_RISING>,
             <0x2 0x17 0x04 IRQ_TYPE_EDGE_RISING>,
             <0x2 0x17 0x05 IRQ_TYPE_EDGE_RISING>,
             <0x2 0x17 0x06 IRQ_TYPE_EDGE_RISING>,
             <0x2 0x17 0x07 IRQ_TYPE_EDGE_RISING>;

        interrupt-names = "or-rid-detect-change",
                  "vpd-detect",
                  "cc-state-change",
                  "vconn-oc",
                  "vbus-change",
                  "attach-detach",
                  "legacy-cable-detect",
                  "try-snk-src-detect",
                  "sig-tx",
                  "sig-rx",
                  "msg-tx",
                  "msg-rx",
                  "msg-tx-failed",
                  "msg-tx-discarded",
                  "msg-rx-discarded",
                  "fr-swap";
}

---
bod





[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux