On 2/14/2024 3:13 PM, Andrew Lunn wrote: > Energy Efficient Ethernet should always be negotiated with the link > peer. Don't include SUPPORTED_Autoneg in the results of get_eee() for > supported, advertised or lp_advertised, since it is > assumed. Additionally, ethtool(1) ignores the set bit, and no other > driver sets this. > > Signed-off-by: Andrew Lunn <andrew@xxxxxxx> > --- I checked the git blame for both igc, and i40e both in-tree and in our out-of-tree drivers which have this code. There is no explanation given and it was just part of the original commits for implementing EEE support for these two drivers. I can't find any trace of a justification for this. Reviewed-by: Jacob Keller <jacob.e.keller@xxxxxxxxx>
