On Sun, Feb 11, 2024 at 10:50:59PM +0200, Andy Shevchenko wrote: > > +static struct i2c_driver anx7428_driver = { > > + .driver = { > > + .name = KBUILD_MODNAME, > > Strictly speaking this is an ABI and we don't want it to be changed in > case of filename change. Personally I _always_ prefer it be open > coded. No, it's not an abi, driver names can, and do, change, nothing should ever rely on this. So using KBUILD_MODNAME is fine. thanks, greg k-h