Hi Abhishek, > +#define UCSI_CONCAP_FLAG_PARTNER_PD_MAJOR_REV_AS_BCD(_f_) \ > + (UCSI_CONCAP_FLAG_PARTNER_PD_MAJOR_REV(_f_) << 8) Can you replace this with a common HEADER_REV_AS_BCD macro that can be used for both GET_CONNECTOR_CAPABILTY and GET_CABLE_PROPERTY? Also, the USB PD major revision value in the message header is one less than the revision (PD Spec section 6.2.1.1.5). So, we need to add 1 before shifting. Thanks, Jameson
