On Tue, Feb 6, 2024 at 2:18 AM Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> wrote: > > Hi Abhishek, > > On Mon, Feb 05, 2024 at 02:05:38PM -0800, Abhishek Pandit-Subedi wrote: > > Hi Heikki, > > > > Friendly ping to review this patch (I see you added Reviewed-by to the > > other two in this series). > > I think Prashant said that he prefers macros with those version checks, > and I kinda agree. But I'll leave this to you to decide. I think > that's also something that can be improved later. Yeah, the macro strikes me as unnecessary here. Anyhow, for the rest of it: Reviewed-by: Prashant Malani <pmalani@xxxxxxxxxxxx>
