On 06.02.24 16:22, Matthias Kaehlcke wrote: > On Tue, Feb 06, 2024 at 04:05:15PM +0100, Javier Carrasco wrote: >> On 06.02.24 15:32, Mark Brown wrote: >>> On Tue, Feb 06, 2024 at 02:59:34PM +0100, Javier Carrasco wrote: >>> >>>> The XMOS XVF3500 VocalFusion Voice Processor[1] is a low-latency, 32-bit >>>> multicore controller for voice processing. >>> >>> Acked-by: Mark Brown <broonie@xxxxxxxxxx> >>> >>> though... >>> >>>> + vdd-supply: >>>> + description: >>>> + Regulator for the 1V0 supply. >>>> + >>>> + vdd2-supply: >>>> + description: >>>> + Regulator for the 3V3 supply. >>> >>> ...it's a bit weird that the supplies are named like this, usually >>> there'd be some sort of meaningful name (even if it's just VDD_1V0 and >>> VDD_3V3 or something). Are you sure these are the actual names? >> >> The names in the datasheet are vdd for the 1V0 supply and vddio for the >> 3V3 supply. I named the latter vdd2 instead because this device does not >> have its own driver and instead it uses the onboard_usb_hub generic >> driver, where the supplies are named vdd and vdd2. >> >> Those are the names used for devm_regulator_bulk_get(). Is that not the >> right way to match them? > > If desired the driver could be extended to support device specific regulator > names through struct onboard_hub/dev_pdata. the onboard_usb_hub driver as well and their supplies are named vdd and vdd2: Documentation/devicetree/bindings/usb/cypress,hx3.yaml I took a look at its datasheet and there is no vdd2 as such, so I think we are in a similar situation here. Actually that device requires five supplies and they have been grouped into vdd and vdd2 according to their voltage level. Best regards, Javier Carrasco
