Re: [PATCH] USB: musb: fix compiling warning with min() macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 10, 2009 at 04:20:33AM +0100, ext Mike Frysinger wrote:
From: Cliff Cai <cliff.cai@xxxxxxxxxx>

Current musb gadget dma code produces the warning:
drivers/usb/musb/musb_gadget.c: In function 'txstate':
drivers/usb/musb/musb_gadget.c:312: warning: comparison of distinct
                                            pointer types lacks a cast

So switch to min_t(size_t, ...).

Signed-off-by: Cliff Cai <cliff.cai@xxxxxxxxxx>
Signed-off-by: Mike Frysinger <vapier@xxxxxxxxxx>

This won't be necessary if we apply the dma mode1 before, but I guess it's better to take this one as mode1 dma might still have some comments. BTW, could you fetch the mode1 dma patches and test them on your board to see if we need to change anything on those patches ?

I'm taking this patch and queueing already.

if you want I have the patches on top of current greg's queue + linus-2.6.git, it's avaialable on [1]

[1] git://gitorious.org/usb/usb.git

--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux